Add institution type data #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add this functionality to select institution type in create-provider |
litvinets
requested changes
Jun 7, 2022
Comment on lines
48
to
52
| this.store.dispatch(new GetInstitutionStatus()); | ||
| this.institutionStatuses$ | ||
| .pipe( | ||
| filter((institutionStatuses) => !!institutionStatuses.length), | ||
| takeUntil(this.destroy$) |
There was a problem hiding this comment.
revert this change please, this field is still needed.
litvinets
requested changes
Jun 11, 2022
| @@ -1,22 +1,23 @@ | |||
| import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; | |||
| import { Component, EventEmitter, Input, Output, OnInit } from '@angular/core'; | |||
There was a problem hiding this comment.
remove unused imports (output as I see)
| @@ -29,6 +30,7 @@ export class ProviderInfoComponent implements OnInit { | |||
| readonly ownershipType: typeof OwnershipType = OwnershipType; | |||
| readonly ownershipTypeUkr = OwnershipTypeUkr; | |||
| readonly providerTypeUkr = ProviderTypeUkr; | |||
| readonly institutionTypes = InstitutionTypes; | |||
There was a problem hiding this comment.
add empty row after readonly fields
| </mat-select> | ||
| </mat-form-field> | ||
|
|
||
|
|
| }); | ||
| } | ||
|
|
||
| ngOnInit(): void { | ||
| this.store.dispatch(new GetInstitutionStatus()); | ||
| this.provider && this.activateEditMode(); | ||
| this.passPhotoFormGroup.emit(this.PhotoFormGroup); | ||
| console.log(this.PhotoFormGroup) |
litvinets
approved these changes
Jun 11, 2022
litvinets
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sp cabinet] "Тип закладу" block is missing in the description of institution #977
['Редагування закладу' page] 'Тип закладу' drop-down box is not displayed #901